x86emul: drop dead code from SYSENTER handling
authorJan Beulich <jbeulich@suse.com>
Thu, 8 Dec 2016 11:20:59 +0000 (12:20 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 8 Dec 2016 11:20:59 +0000 (12:20 +0100)
There's no point reading CS - all of the fields get set from scratch
right afterwards. Also correct a wrong comment.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/x86_emulate/x86_emulate.c

index dfa3c6cac1f636da3fb770a4725bc5c43b2ea9fb..7092c4f25deb0895ea17e7fcfd5e204a0039d3ee 100644 (file)
@@ -4863,12 +4863,10 @@ x86_emulate(
 
         _regs.eflags &= ~(EFLG_VM | EFLG_IF | EFLG_RF);
 
-        fail_if(ops->read_segment == NULL);
-        ops->read_segment(x86_seg_cs, &cs, ctxt);
         cs.sel = msr_content & ~3; /* SELECTOR_RPL_MASK */
         cs.base = 0;   /* flat segment */
         cs.limit = ~0u;  /* 4GB limit */
-        cs.attr.bytes = lm ? 0xa9b  /* L+DB+P+S+Code */
+        cs.attr.bytes = lm ? 0xa9b  /* G+L+P+S+Code */
                            : 0xc9b; /* G+DB+P+S+Code */
 
         sreg.sel = cs.sel + 8;